feat(android): add video select support for android platform.#290
Closed
mylmz10 wants to merge 5 commits intoNativeScript:masterfrom
Closed
feat(android): add video select support for android platform.#290mylmz10 wants to merge 5 commits intoNativeScript:masterfrom
mylmz10 wants to merge 5 commits intoNativeScript:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Contributor
Author
|
@tgpetrov I fill out the form. |
Contributor
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Contributor
Author
|
@DimitarTodorov I noticed there was one missing and I wanted to be a contributor but it was not. I see that merged and published your commit, thanks(!). |
xuhcc
added a commit
to xuhcc/nativescript-imagepicker
that referenced
this pull request
Aug 27, 2019
…on Android Currently everything except images and videos is not selectable (text for example). This commit fixes it and partly reverts changes made in NativeScript#290 and NativeScript#291.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Videos tabs not shown on picker area.
What is the new behavior?
Videos tabs shown on picker area.
Implements #175, #60.